CWE-1116: Inaccurate Source Code Comments

How it's found

Inaccurate Source Code Comments is typically found by tracing untrusted input from where it enters the system to the point where it is used without the check or neutralization this weakness describes, combining manual code review with dynamic testing.

Vulnerable vs. safe

int pt_weight = 83;int mg_per_kg = 3;int daily_dose = 0;// Add the patient weight and Mg/Kg to calculate the correct daily dosedaily_dose = pt_weight * mg_per_kg;return dosage;public static void main(String[] args) {}public class Main {}

int pt_weight = 83;int mg_per_kg = 3;int daily_dose = 0;// Multiply the patient weight and Mg/Kg to calculate the correct daily dosedaily_dose = pt_weight * mg_per_kg;return dosage;public static void main(String[] args) {}public class Main {}

Consequences

• Reduce Maintainability: This issue makes it more difficult to maintain the product, which indirectly affects security by making it more difficult or time-consuming to find and/or fix vulnerabilities. It also might make it easier to introduce vulnerabilities.
• Increase Analytical Complexity: When a comment does not accurately reflect the associated code elements, this can introduce confusion to a reviewer (due to inconsistencies) or make it more difficult and less efficient to validate that the code is implementing the intended behavior correctly.

Mitigations

• Implementation: Verify that each comment accurately reflects what is intended to happen during execution of the code.

Where this fits in a TurboPentest engagement

This weakness is not covered by the automated black-box pentest. IntegSec pentesters cover it in a manual engagement.

Frequently asked questions

Related CWEs

• Class weakness
  CWE-1078: Inappropriate Source Code Style or Formatting